Merge pull request #4327 from abhinav-upadhyay/use-with-to-read-file

Use the with statement to open a file.
ipython · Oct 2, 2013 · 6676b20 · 6676b20
2 parents 4d6aad3 + ef5a828
commit 6676b20
Showing 1 changed file with 2 additions and 3 deletions.
diff --git a/IPython/core/magics/code.py b/IPython/core/magics/code.py
@@ -402,9 +402,8 @@ def _edit_macro(self,mname,macro):
         self.shell.hooks.editor(filename)
 
         # and make a new macro object, to replace the old one
-        mfile = open(filename)
-        mvalue = mfile.read()
-        mfile.close()
+        with open(filename) as mfile:
+            mvalue = mfile.read()
         self.shell.user_ns[mname] = Macro(mvalue)
 
     @skip_doctest