Skip to content

Commit

Permalink
remove unregister trait-change callback in ExtensionManager.__del__
Browse files Browse the repository at this point in the history
Due to reference cycles, this can never be called at a time when it would matter,
but seems to cause weird crashes sometimes during interpreter teardown on Python 3.5 with traitlets 4.1.
  • Loading branch information
minrk committed Nov 26, 2015
1 parent 3e9017c commit dc1d1d4
Showing 1 changed file with 0 additions and 5 deletions.
5 changes: 0 additions & 5 deletions IPython/core/extensions.py
Expand Up @@ -59,11 +59,6 @@ def __init__(self, shell=None, **kwargs):
)
self.loaded = set()

def __del__(self):
self.shell.on_trait_change(
self._on_ipython_dir_changed, 'ipython_dir', remove=True
)

@property
def ipython_extension_dir(self):
return os.path.join(self.shell.ipython_dir, u'extensions')
Expand Down

0 comments on commit dc1d1d4

Please sign in to comment.