BUG: wrong default parameter in ask_yes_no #1026

Closed
xuyuan opened this Issue Nov 21, 2011 · 1 comment

Comments

Projects
None yet
2 participants
@xuyuan

xuyuan commented Nov 21, 2011

How to reproduce?

call reset magic, give empty answer, the default 'n' has no affects

Issue:

reset magic call core.interactiveshell.ask_yes_no with any default value,

and

utils.io.ask_yes_no accepts string as default answer, while core.interactiveshell.ask_yes_no pass True in!

Solution:

give 'n' in reset magic, and fix the default answer of core.interactiveshell.ask_yes_no

@minrk

This comment has been minimized.

Show comment
Hide comment
@minrk

minrk Nov 21, 2011

Member

Thanks! this particular case doesn't actually occur in master anymore (because 'n' is now given as default), but the bug still persists, even though it never comes up.

Member

minrk commented Nov 21, 2011

Thanks! this particular case doesn't actually occur in master anymore (because 'n' is now given as default), but the bug still persists, even though it never comes up.

@minrk minrk closed this in 30385c4 Nov 22, 2011

mattvonrocketstein pushed a commit to mattvonrocketstein/ipython that referenced this issue Nov 3, 2014

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment