BUG: wrong default parameter in ask_yes_no #1026

Closed
xuyuan opened this Issue Nov 21, 2011 · 1 comment

Projects

None yet

2 participants

@xuyuan

How to reproduce?

call reset magic, give empty answer, the default 'n' has no affects

Issue:

reset magic call core.interactiveshell.ask_yes_no with any default value,

and

utils.io.ask_yes_no accepts string as default answer, while core.interactiveshell.ask_yes_no pass True in!

Solution:

give 'n' in reset magic, and fix the default answer of core.interactiveshell.ask_yes_no

@minrk
IPython member

Thanks! this particular case doesn't actually occur in master anymore (because 'n' is now given as default), but the bug still persists, even though it never comes up.

@minrk minrk added a commit that closed this issue Nov 22, 2011
@minrk minrk fix default value in interactiveshell.ask_yes_no
was True, should be None

closes #1026
30385c4
@minrk minrk closed this in 30385c4 Nov 22, 2011
@mattvonrocketstein mattvonrocketstein pushed a commit to mattvonrocketstein/ipython that referenced this issue Nov 3, 2014
@minrk minrk fix default value in interactiveshell.ask_yes_no
was True, should be None

closes #1026
634d2f2
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment