Skip to content

HTTPS clone URL

Subversion checkout URL

You can clone with HTTPS or Subversion.

Download ZIP

Loading…

BUG: wrong default parameter in ask_yes_no #1026

Closed
xuyuan opened this Issue · 1 comment

2 participants

@xuyuan

How to reproduce?

call reset magic, give empty answer, the default 'n' has no affects

Issue:

reset magic call core.interactiveshell.ask_yes_no with any default value,

and

utils.io.ask_yes_no accepts string as default answer, while core.interactiveshell.ask_yes_no pass True in!

Solution:

give 'n' in reset magic, and fix the default answer of core.interactiveshell.ask_yes_no

@minrk
Owner

Thanks! this particular case doesn't actually occur in master anymore (because 'n' is now given as default), but the bug still persists, even though it never comes up.

@minrk minrk closed this issue from a commit
@minrk minrk fix default value in interactiveshell.ask_yes_no
was True, should be None

closes #1026
30385c4
@minrk minrk closed this in 30385c4
@ellisonbg ellisonbg referenced this issue from a commit
Commit has since been removed from the repository and is no longer available.
@mattvonrocketstein mattvonrocketstein referenced this issue from a commit in mattvonrocketstein/ipython
@minrk minrk fix default value in interactiveshell.ask_yes_no
was True, should be None

closes #1026
634d2f2
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Something went wrong with that request. Please try again.