Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

BUG: wrong default parameter in ask_yes_no #1026

Closed
xuyuan opened this issue Nov 21, 2011 · 1 comment
Closed

BUG: wrong default parameter in ask_yes_no #1026

xuyuan opened this issue Nov 21, 2011 · 1 comment
Milestone
0.12

Comments

@xuyuan
Copy link

xuyuan commented Nov 21, 2011

How to reproduce?

call reset magic, give empty answer, the default 'n' has no affects

Issue:

reset magic call core.interactiveshell.ask_yes_no with any default value,

and

utils.io.ask_yes_no accepts string as default answer, while core.interactiveshell.ask_yes_no pass True in!

Solution:

give 'n' in reset magic, and fix the default answer of core.interactiveshell.ask_yes_no
@minrk
Copy link
Member

minrk commented Nov 21, 2011

Thanks! this particular case doesn't actually occur in master anymore (because 'n' is now given as default), but the bug still persists, even though it never comes up.

@minrk minrk closed this as completed in 30385c4 Nov 22, 2011
mattvonrocketstein pushed a commit to mattvonrocketstein/ipython that referenced this issue Nov 3, 2014
@minrk
fix default value in interactiveshell.ask_yes_no
634d2f2 
was True, should be None

closes ipython#1026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
0.12
Development

No branches or pull requests
2 participants
@minrk @xuyuan