New bug: Notebook asks for confirmation to leave even saved pages. #1058

Closed
fperez opened this Issue Nov 28, 2011 · 3 comments

Projects

None yet

2 participants

@fperez
Member
fperez commented Nov 28, 2011

@stefanv, this was unfortunately introduced by your changes in #1036, and I didn't notice it initially (we really need an automated test suite for the JS code, badly).

Now, the alert dialog comes up for any closing of a page, even if it was already saved. Furthermore, the message which used to read

You have unsaved changes that will be lost if you leave this page.

now simply says true. I'm going to try to see if I can quickly fix it, but if I can't I'll just revert back the commit (with git revert) so we can fix things later. Now I'm worried that there may be other new bugs in the notebook introduced by this which we haven't seen yet.

Lesson learned: never merge again a 'cleanup' on javascript, since its semantics regarding this stuff are so finicky that a supposedly purely stylistic fix can break code.

@fperez
Member
fperez commented Nov 28, 2011

I've been looking through the code, and I can't quite understand what is causing this problem. Let me know if you can track it down, if not for now we'll need to revert. A bug is too high a price to pay to keep a syntax nanny happy :)

@stefanv
stefanv commented Nov 28, 2011

@fperez I don't see this on my branch at all--are you sure my changes caused the problem? I'll have another look tomorrow morning.

@stefanv
stefanv commented Nov 28, 2011

I just tried the latest version of the notebook (it seems the patch hasn't been reverted yet), and that works fine here as well (I did a reload to make sure I'm using the newest js).

@fperez fperez closed this in 52fc956 Nov 28, 2011
@mattvonrocketstein mattvonrocketstein pushed a commit to mattvonrocketstein/ipython that referenced this issue Nov 3, 2014
@fperez fperez Fix bug where "don't leave" dialog was appearing when not needed in nb.
Closes #1058
73ee0e0
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment