updated vim-ipython (pending) #1120
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ivanov/vim-ipython 3b62ca30c4cd3912532855279cdd161d2ef3c640
|
Does this need any further updates, or should we just merge it as-is? I think we're about ready to cut the first RC in a day or two. |
|
@ivanov: last call... Do you want us to wait on this one for further updates, or should we go ahead and merge? I'd like to get to the RC pretty soon... |
|
sorry, I've been a bit occupied - please merge as is |
|
Was it you taking the pic or holding the sign? |
|
OK, merged and pushed. Thanks! |
|
It was me holding the sign - I know it's not PEP-8 compliant - I'll pylint and pyflakes and otherwise PEP8-proof my future political activity. |
|
Otherwise we won't commit! :) |
mattvonrocketstein
pushed a commit
to mattvonrocketstein/ipython
that referenced
this pull request
Nov 3, 2014
Various small updates to vim integration. Closes ipython#1120, rebased to avoid unnecessary recursive merge.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Just wanted to place this in the queue to make sure that an updated version goes into 0.12
I wanted to add this but not have it merged until 0.12 RCs are being cut, but in case I don't get to it again, this version is a big improvement over what ships with ipython currently.