New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
test_history failure #11372
Comments
Which version of Python are you running that on ? Look at the version of sqlite as well. |
Here are the python and sqlite versions:
And some other I guess might be relevant:
|
The problem also appears to be happening in version 6.5. It looks like the problem first occurred when we switched from sqlite3 3.24.0 to 3.25.0. |
actually for So why 4 instead of 1... ? It may be that when we request |
I missed that. But I don't really know anything about SQL so I don't know why it might be happening. I have confirmed the problem still occurs with sqlite 3.25.2, the latest version. |
I'm not a SQL expert either, from what I can tell the test failure are not
critical. Would a "known fail" marker help you to package for openSUSE or
do you prefer to find the root cause?
…On Sun, Oct 14, 2018, 12:28 Todd ***@***.***> wrote:
I missed that. But I don't really know anything about SQL so I don't know
why it might be happening. I have confirmed the problem still occurs with
sqlite 3.25.2, the latest version.
—
You are receiving this because you commented.
Reply to this email directly, view it on GitHub
<#11372 (comment)>,
or mute the thread
<https://github.com/notifications/unsubscribe-auth/AAUez9oGI6J02rTiDIfuzUCrpY71axO9ks5uk5B1gaJpZM4XMOVJ>
.
|
I don't know how serious the bug is so I would defer to your judgement. Of course a real fix is preferable, but if you think the problem is minor enough we can go with a known fail for the time being. |
@LucianaMarques you were looking for something easy, that should't be too hard to add a "@skip_if" with a condition like... We can delay fixing that to later. |
@Carreau thank you, I'll give it a try today! |
@Carreau I'm having trouble to use @skip_if, I have never used it and found no docs on it (or I'm not searching for it properly... ), do you have any tutorials/docs recommendations? |
@LucianaMarques Whenever I start coding in a new area, I try to find examples in the current code. If you are on a Unix-based system you could use |
I think it's without underscore on IPython codebase. For example there. @dsblank have you tried RipGrep ? Really good: skip .git by default, search recursively by default, color highlight, and filter by file types. Fr example search for skipif only in python files:
... and 10x faster on my machine. |
As promissed, my pull request. |
Skip_if has been added, I'll left this one open to go to the root of the issue. Thanks ! |
For future reference and maybe a real fix sometime, this appears to be happening because ipython uses an SQL "GROUP BY" clause to squash duplicates, while also selecting and ordering by columns that are neither grouping columns nor aggregate functions (session and line). Neither SQL nor sqlite specify from which row of each resulting group the values for those so-called "bare" columns will be drawn, and apparently sqlite's actual behavior changed in that regard. I tried a couple of variations on the generated SQL, with no success against sqlite3 3.26.0. There are certainly ways to do it, but there's a question of the size of the changes required and their effect on search performance. |
I am trying to package ipython 7.0.1 for openSUSE and I am getting the following error in the unit tests:
It looks like the last two list elements have switched places but I don't know why that might be the case.
EDIT:
We can likely fix this issue in two steps:
The text was updated successfully, but these errors were encountered: