-
-
Notifications
You must be signed in to change notification settings - Fork 4.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
A lot of testerrors #1148
Comments
Arg, yes. Since that was a test specifically for a bug fixed by the |
Oops, I guess we overlooked changing the function signature for that implementation of arg_split. I'm not seeing any failures on Linux, so I guess that bug is in the Windows version of arg_split. Has that test passed at any time since your PR #1064? There's probably no good tools to handle the mixture of command-line syntax and Python code we're trying to use here. |
@takluyver - it's a new test, so it wasn't around when 1064 went in. Yes, it's definitely a 'bug' in arg_split, but only insofar as we use arg_split for things other than passing command-line args to subprocesses, which we probably shouldn't. I think the answer is that we should force using the _process_common arg_split in magics. @jstenar - is there anything that your new arg_split does that is actually necessary in magics? The uglier alternative is that we can fall _process_common.arg_split() from win32.argsplit if strict=False, but I would rather not do that unless it's strictly necessary. |
Min RK skrev 2011-12-13 19:52:
Yes it strips out enclosing quotation marks and I believe there are In [1]: import IPython.utils._process_win32 as pw In [2]: import IPython.utils._process_common as pc In [3]: pw.arg_split(u'%run "kalle.py"') In [4]: pc.arg_split(u'%run "kalle.py"') |
Thanks, I saw your original PR/bug report, and now I better understand the situation. I started off with the assumption that this was old code, not new. See PR #1149 for a band-aid solution. |
if strict=False, falls back on shlex-based split from _process_common closes ipython#1148 closes ipython#1149
I get 3 failures in IPython.testing, 16 errors and 10 failures in IPython.core on master 1184eb4, on windows python2.6.
All but one go away if I add the strict keyword argument to arg_split in _process_win32.py
After that only one error is remaining, and that one is included below. Is this related to arg_split differences on windows or is it present in Linux as well?
The text was updated successfully, but these errors were encountered: