Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Already on GitHub? Sign in to your account

Broken type filter in magic_who_ls #119

Closed
jdmarch opened this Issue May 17, 2010 · 2 comments

Comments

Projects
None yet
2 participants
Contributor

jdmarch commented May 17, 2010

%who_ls (hence also %who and %whos) mistakenly interpret any type filter as str.
Broken by http://github.com/ipython/ipython/commit/c870360cc5e0b06054ab92a649f034f47824bf3b
Fixed by http://github.com/jdmarch/ipython/commit/322eec22bf6fc65d34a6ebe7e4c4728c8a2cd4e8
which also removes lots of trailing white space (was that a no-no?)

Contributor

jdmarch commented May 17, 2010

Two newbie questions:

  1. Should something trivial like this be posted to the dev list or does opening an issue suffice?
  2. The white-space cleanup makes it harder to view the diff on github (unlike with gitk which can ignore whitespace differences). So is it better not to do such cleanup?
Owner

minrk commented Feb 21, 2011

This is very stale, but I just noticed it.

This issue has been fixed in 0.11.dev with b6416bc. Judging by comments on the commit, it was fixed previously, but it's definitely working now.

@minrk minrk pushed a commit to minrk/ipython that referenced this issue Jul 1, 2013

@Carreau Carreau Merge pull request #119 from minrk/nbcv
don't use custom nbcv for plain-Python config files
3dc478c

This issue was closed.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment