should dv.sync_import print failed imports ?

[Carreau]

Hi,
I'm trying parallel magic, I just feel that sync_import should at least warn user if some import have failed/are not done, or at least state in the docstring that if import failed/are not done it stays silent.

Docstring don't mention local keyword, (should it ? even if no yet implemented ? )

[minrk]

Yes and yes. The comments in the code clearly state:

            if not local:
                # ignore import errors if not doing local imports
                pass

But there needs to be an else: raise after that to actually raise the error.

[minrk]

should be fixed

[Carreau]

Yes, it works.
just one other detail, maybe due to @contexmanager
When ? or ?? docstring state :
Definition: dv.sync_imports(*args, **kwds) which don't cite the definition of the non decorated function. Same with temp_flags but there is no parameters so not really important.