use self.kernel_manager_class in qtconsoleapp #1257
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
This looks great, merge whenever you want. |
minrk
added a commit
that referenced
this pull request
Jan 16, 2012
use self.kernel_manager_class in qtconsoleapp Subclasses of QtConsoleApp can now override kernel_manager_class with their own version.
minrk
added a commit
that referenced
this pull request
Jan 18, 2012
use self.kernel_manager_class in qtconsoleapp Subclasses of QtConsoleApp can now override kernel_manager_class with their own version.
mattvonrocketstein
pushed a commit
to mattvonrocketstein/ipython
that referenced
this pull request
Nov 3, 2014
use self.kernel_manager_class in qtconsoleapp Subclasses of QtConsoleApp can now override kernel_manager_class with their own version.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
ShellApp derivatives have a kernel_manager_class, so that it's easier to change what should be used in subclasses. The QtConsole was not updated to use this for tabs other than the first. This small PR makes that change.