New tooltip for notebook #1509

Carreau · 2012-03-19T16:55:00Z

This is an answer to fix #1498 (tooltip keyboard shortcuts (feature request)), that also contain all the code from #1417 (new completer) because it rely on some change made in it.

It introduces tooltip in it's own class, and allows differrent behaviour when you press several time. (see discusion in #1498). Plus some aesthetic change when trying to get a tooltip from the far right of the windows.

If you can test and give feedback on usability/ cross browser css compatibility, i'll focus on tidying/commenting the code later.

Invoking @fawce , to be sure he get the notification.

Carreau · 2012-03-20T08:39:39Z

@hadmack , I open a PR if you find some bugs.

Thanks for your work on this. Tooltips are a helpful feature.

Thanks, I'm writing this because I feel the need for this often, but I also lack JS background... And all the credit have to go to the dev team which made a great api and easy to modifie code.

Carreau · 2012-03-23T13:21:22Z

rebased on master and forced pushed.
didn't had time to make more changes.

Carreau · 2012-03-30T14:44:25Z

some cleaning and example on how to configure. rebased on master.

@hadmack, you can execute this as a markdown cell of your nb :

## tooltip configuration
<script>
    IPython.tooltip.tabs_functions[1] = function(){IPython.tooltip.showInPager() }
</script>

And you'll have the pager on second keypress.

fperez · 2012-04-15T01:51:53Z

@Carreau, sorry but this one has a conflict right now, no idea what caused it. Could you rebase it so we can start reviewing it and testing it? Hopefully now that we have the PR queue a bit more controlled, we can move more quickly on yours.

Carreau · 2012-04-15T13:09:58Z

@fperez rebased and forced push.
It contains a .less file that compile to .css (for the tooltip, it's easier to have variable for the css when tweeking it), when you'll be OK with the PR, I can remove the less file if you want.

recap of the changes :

Everything from the new-completer (Notebook Completer Class #1417)
tooltip in it's own separated class
new css
small arrow on top of the tooltip more or less on right or left depending on wether the cursor is on the left or right of codemirror instance when invoking.
different behaviour depending on how many time you press tab. [*]
- one time : classical tooltip
- two : expand the tooltip (equivalent than clicking +button)
- three: make the tooltip 'sticky' for 10 sec (won't be discarded by keyboard input)
- four : exec function? on behalf of the current cell (equivalent than clicking ^ button)[**]

[*] If you are ok with that behaviour, I can write that somewhere in the docs/ notebook example.
[**] When the widget API is in place I would like to change this thing, because it increments the prompt number of the cell.

[edit] for the record, conflicting commit was 0960f3b ~L23 , add of this.clear_out_timeout = null;[/edit]

Carreau · 2012-04-28T09:46:38Z

rebased and forced push to avoid conflict.

more feature like -completion based on 2 sources : * introspection in kernel * context of current cell (complete with matching words) * each source has its color in the completer

adding 'use strict' in some place to be more agressive on the delaration of the variables. clean name and details here and there

pylab.l<tab><tab> would be replace by .l because of a bug in common start finding .l on the fifth position of pylab.start.

this structure (IPython.utils.keycodes) add some common keycodes like tab...etc and start modifying codecell.js to use it for better readability

if having problem with Tab Completion try to revese this commit

and modifies some file to use it

Completion source based on context is smarter and use codemirror token mecanisme to propose completions, instead of just plitting text at whitespace and before dots.

temporarly (or maybe not) use less css to produce the css for the tooltip.

don't forget to reenqble keyframe with a more recent less compiler

consecutives tab pressing with tooltip does : - fisrt : show it - second : expand it - third : make it sticky for 10s (typing wont dismiss it) - forth : send the content into the Pager

construct a completer only if the class exist otherwise print view won't load.

Carreau · 2012-04-30T16:03:37Z

rebased and forced push to avoid conflict.

ellisonbg · 2012-05-03T22:49:20Z

I have refactored now the Kernel, Notebook and CodeCell work in this PR: #1697. That PR will conflict with this one. I think the best way of handling it is to merge that first, then rebase this on top of it.

Carreau · 2012-05-04T07:28:03Z

As you wish, I'll might be a little busy in the next few days, but I will try to take a look.
We can also try to merge #1509 and #1697 together then make a PR of the 2 into master.
I keep you informed.

ellisonbg · 2012-05-04T19:12:18Z

Let's try to merge #1697 first and then rebase/merge 1509 on top of
that. I think it will be cleaner to finish the reviews that way.

On Fri, May 4, 2012 at 12:28 AM, Bussonnier Matthias
reply@reply.github.com
wrote:

As you wish, I'll might be a little busy in the next few days, but I will try to take a look.
We can also try to merge #1509 and #1697 together then make a PR of the 2 into master.
I keep you informed.

Reply to this email directly or view it on GitHub:
#1509 (comment)

Brian E. Granger
Cal Poly State University, San Luis Obispo
bgranger@calpoly.edu and ellisonbg@gmail.com

Carreau · 2012-05-04T19:38:58Z

This PR has more than 30 commits , it will be hard and long to rebase all on top once more ...
Wherease #1697 is 'only' 1 commit which would be easier to rebase... unless you know another method

May I suggest to merge #1509 and #1697 in one branch and merge it into master all at once ?

ellisonbg · 2012-05-07T16:03:40Z

@Carreau I like this idea. Can you create that combined branch and push it as a branch in the ipython org so both of us can push to it. Once that happens I will pick up the work on it.

Carreau · 2012-05-07T20:58:43Z

@ellisonbg
ok, done here

I rebased both branches on master,
cherry pick yours on top of mine
fix the conflicts, and start tweek the code so that is worked (and retab)
start cleaning the code

I'll open a new PR...

Carreau · 2012-05-08T10:06:00Z

Closing as it is superseeded by #1711

Carreau mentioned this pull request Mar 30, 2012

Notebook Completer Class #1417

Closed

Carreau and others added 23 commits April 30, 2012 17:37

implement the completer in a separate class

b7369db

more feature like -completion based on 2 sources : * introspection in kernel * context of current cell (complete with matching words) * each source has its color in the completer

use strict and clean a little.

7a8337b

adding 'use strict' in some place to be more agressive on the delaration of the variables. clean name and details here and there

fix and retab javascript

f1e5e1b

comment more

1955bd2

fix replace range bug

84dd355

pylab.l<tab><tab> would be replace by .l because of a bug in common start finding .l on the fifth position of pylab.start.

add a keycodes structure to utils

a33db7c

this structure (IPython.utils.keycodes) add some common keycodes like tab...etc and start modifying codecell.js to use it for better readability

import Utils keycodes into the completer

f0cd673

Removing some code that seem not to be usefull anymore

91c6b1d

if having problem with Tab Completion try to revese this commit

add ctrlKey.which to utils

0a15d4a

and modifies some file to use it

be smarter for context completion

4bfa1fc

Completion source based on context is smarter and use codemirror token mecanisme to propose completions, instead of just plitting text at whitespace and before dots.

move more code into the completer itself

bfa1cfd

clean code, remove duplicate unused lines

8d81326

more cleaning

6a8d2df

tooltip to mac

97ca8e0

tooltip to mac

7f0b49c

new tooltip style

b27a739

improve new tooltip

23d9d19

change new tooltip appearence

5d9f920

temporarly (or maybe not) use less css to produce the css for the tooltip.

comment a little

edf5112

play with tooltip growing css

688b001

don't forget to reenqble keyframe with a more recent less compiler

fix scrolltop

a9a037c

animate tooltip position

d6d4916

animation if already shown

2672bec

Carreau added 13 commits April 30, 2012 17:38

shorten prearrow

a89fee3

move arow with tooltip positoin

d1404a4

call tooltip by cell reference

a52a620

call tooltip after time

7760c7b

almost all logic in tooltip.js, padding right button

56949cc

remove global

549735d

multiple tooltip action

ae3ac0e

consecutives tab pressing with tooltip does : - fisrt : show it - second : expand it - third : make it sticky for 10s (typing wont dismiss it) - forth : send the content into the Pager

should fix click on close works when sticky

d5ea8c4

clean and comment tooltip file

158c5a6

remove console.log

489616e

fix cancel_stick typo

c7ad7ea

fix typo that->this

6385886

fix print view

56adc0a

construct a completer only if the class exist otherwise print view won't load.

Carreau mentioned this pull request May 4, 2012

Major refactoring of the Notebook, Kernel and CodeCell JavaScript. #1697

Closed

Carreau mentioned this pull request May 7, 2012

[notebook] Make pager resizable, and remember size... #1705

Merged

Carreau mentioned this pull request May 7, 2012

New Tooltip, New Completer and JS Refactor #1711

Merged

Carreau closed this May 8, 2012

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

New tooltip for notebook #1509

New tooltip for notebook #1509

Carreau commented Mar 19, 2012

Carreau commented Mar 20, 2012

Carreau commented Mar 23, 2012

Carreau commented Mar 30, 2012

fperez commented Apr 15, 2012

Carreau commented Apr 15, 2012

Carreau commented Apr 28, 2012

Carreau commented Apr 30, 2012

ellisonbg commented May 3, 2012

Carreau commented May 4, 2012

ellisonbg commented May 4, 2012

Carreau commented May 4, 2012

ellisonbg commented May 7, 2012

Carreau commented May 7, 2012

Carreau commented May 8, 2012

New tooltip for notebook #1509

New tooltip for notebook #1509

Conversation

Carreau commented Mar 19, 2012

Carreau commented Mar 20, 2012

Carreau commented Mar 23, 2012

Carreau commented Mar 30, 2012

fperez commented Apr 15, 2012

Carreau commented Apr 15, 2012

Carreau commented Apr 28, 2012

Carreau commented Apr 30, 2012

ellisonbg commented May 3, 2012

Carreau commented May 4, 2012

ellisonbg commented May 4, 2012

Carreau commented May 4, 2012

ellisonbg commented May 7, 2012

Carreau commented May 7, 2012

Carreau commented May 8, 2012