-
-
Notifications
You must be signed in to change notification settings - Fork 4.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix installing extension from local file on Windows #1633
Conversation
Code looks clean to me, but indeed we need confirmation from @jstenar or someone else with a Windows testing setup. @jdmarch, do you guys test on Windows regularly? Thanks for the work, @takluyver! Go ahead with the merge once someone confirms it's OK on windows. |
At quick look, this PR does not seem to make any difference on WinXP.
Produces 3 errors (test_macro, ...multi-line macro..., and test_extension) and 1 failure (..string escapes) before or after this PR. Whether the test_extension error is a side-effect of the preceding errors I do not know. Possibly several days before I can return to this. |
Thanks for the report, @jdmarch! |
@jdmarch (or anyone who can test on Windows): can you stick the results of that test (i.e. tracebacks) on a pastebin somewhere? Thanks. |
Gah, stupid mistake. Thanks for testing, hopefully it's fixed now. |
Closer but not quite there:
|
Thanks, that one I should have caught on my own machine. If you could test again, that would be great. |
Yes, test_extension passes now on WinXP. |
Thanks, Jonathan. I'll merge this now. |
Fix installing extension from local file on Windows. Closes gh-1479
Thanks guys for the rapid back and forth! Glad to see this in. |
Fix installing extension from local file on Windows. Closes ipythongh-1479
Someone on Windows will need to test that this works. Pinging @jstenar.
Closes gh-1479