-
-
Notifications
You must be signed in to change notification settings - Fork 4.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fixes #1708, failing test in arg_split on windows #1709
Conversation
Does this fix the actual issue, reported in #1632? |
Min RK skrev 2012-05-07 21:08:
At least the steps that caused the crash, ls followed by cd .., does not /Jörgen |
@jstenar : If you run the test suite against this branch, how many failures do you see? The last test on ShiningPanda had 7, so it should be less than that. |
Thomas Kluyver skrev 2012-05-07 21:43:
There are fewer failures now and no new ones. |
Great. No objections from me, then. @minrk, if you're happy with this, go ahead and merge it. |
Looks good to me, but I would like to wait for a quick confirmation from #1632 and then we can merge, closing that issue. |
Test results for commit bbd1f50 merged into master
Not available for testing: python3.1 |
fixes #1708, failing test in arg_split on windows There were a conflicting defintion of CommandLineToArgvW.res_type in _process_win32 and _process_win32_controller. This PR fixes the issue.
fixes ipython#1708, failing test in arg_split on windows There were a conflicting defintion of CommandLineToArgvW.res_type in _process_win32 and _process_win32_controller. This PR fixes the issue.
There were a conflicting defintion of CommandLineToArgvW.res_type in _process_win32 and _process_win32_controller. This PR fixes the issue.