Expose Pygments styles as options #171
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Min, once you finish this one with the --colors changes according to our review/discussion yesterday, I think it will be ready to merge. Thanks for the great job! |
|
Oops, forgot to push that the other night. It's up now. |
|
Merge branch 'minrk-pygments' into trunk Provide full support for all the Pygments styles at the console, and Closed by e6c4eee (pull request) |
|
Thanks a lot for this, very nice feature to have. |
markvoorhies
pushed a commit
to markvoorhies/ipython
that referenced
this pull request
Apr 21, 2011
Provide full support for all the Pygments styles at the console, and properly synchronize with IPython's own Linux/LightBG color schemes. In the long run we need to refactor our internal coloring code to only use CSS, but for now this provides a fairly clean user experience. Closes ipythongh-171 (pull request)
mattvonrocketstein
pushed a commit
to mattvonrocketstein/ipython
that referenced
this pull request
Nov 3, 2014
Provide full support for all the Pygments styles at the console, and properly synchronize with IPython's own Linux/LightBG color schemes. In the long run we need to refactor our internal coloring code to only use CSS, but for now this provides a fairly clean user experience. Closes ipythongh-171 (pull request)
This pull request was closed.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
IPythonWidget already supported using various pygments styles. I just added some flags to ipythonqt, and tweaked the default style code, so that they can be set at launch:
ipythonqt --dark will run IPython with the default dark theme
ipythonqt --style will run IPython using the specific style. Anything pygments accepts will work.
e.g.
ipythonqt --style fruity
The style code also guesses whether a theme is dark or light, and chooses the right stylesheet. This can be overridden if --dark is manually specified.
If you want to use your own css stylesheet, you can pass that with --stylesheet.
No logic was added to the widgets themselves, just the ipythonqt script and a styles file that sets up the defaults.