Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

externals cleanup #1838

Closed
juliantaylor opened this issue Jun 2, 2012 · 4 comments · Fixed by #1839
Closed

externals cleanup #1838

juliantaylor opened this issue Jun 2, 2012 · 4 comments · Fixed by #1839
Milestone

Comments

@juliantaylor
Copy link
Contributor

I had a brief look through the bundled externals.
I noticed that pyparsing does not appear to be used at all and mglob is only used in death-row or quarantined stuff (ipy_fsops.py, ipy_profile_sh.py)

So the pyparsing should be removed an if quarantine and death-row cleanup is planned for 0.13 also mglob.

also docs/source/interactive/shell.txt mentions a mglob magic which does not appear to exist anymore.

@fperez
Copy link
Member

fperez commented Jun 2, 2012

This all sounds very reasonable, any chance you could whip up a PR for it? I'd be OK with removing externals that are only used in quarantine/deathrow, but I'd want to add a quick comment in the user file to the effect of:

This depends on foo.bar that used to be in externals, if this code is updated to run again with current IPython, you may need to reintroduce that file back. In doing so, look for the possibility of achieving the same effect only with the standard library (which may have improved by now, since we currently depend on Python 2.6).

@juliantaylor
Copy link
Contributor Author

which user file?

@fperez
Copy link
Member

fperez commented Jun 2, 2012

Sorry, bad writing: I meant whatever quarantine file may have been using the removed code.

@takluyver
Copy link
Member

Closed by PR #1839

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants