-
-
Notifications
You must be signed in to change notification settings - Fork 4.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
External cleanup #1839
External cleanup #1839
Conversation
added comment about removal to ipy_fsops.py removed use from ipy_profile_sh.py removed documentation on previously removed %mglob magic
We've previously provided pyparsing for third parties to use in their own prefilter transformers, so we shouldn't just remove it with no warning. As a minimum, we should post to the ipython-user list to ask if anyone knows of code that relies on it being there. Apart from that, removing unused code is always good. ;-) |
I don't see why ipython needs to ship 4000 lines of unused (and probably very old) code |
I agree, but we have shipped that in releases up to now. So we need to warn anyone who might have been relying on it that they can't do that as of the next release. (And theoretically, if a lot of code relied on it, we'd deprecate it for a cycle first, but I can't imagine that will happen.) |
Fernando pinged the list, but I would be surprised if anyone tres to make the case that this should still ship in IPython. |
+1, great to see external/ shrinking. |
OK, there were no objections on the mailing list (not that I expected any), and everyone seems happy about this, so I'm merging it now. Thanks, Julian. |
Remove pyparsing and mglob from IPython.externals
Remove pyparsing and mglob from IPython.externals
remove pyparsing external which is unused
remove mglob external which is only used by quarantined code
Closes gh-1838