New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add parallelism to test_pr #1880
Comments
@minrk : I've always avoided running more than one instance of the test suite at a time, because I'm not sure how it would affect tests that require interprocess communications, especially in |
No, it is not safe to do that with the parallel stuff. I think it should be if the IPYTHONDIR is guaranteed to be different for each env. |
What I'd like to do is rig iptest so that each 'test group' is run not only in a new process (which is already the case) but with a new, random and temporary IPYTHONDIR. That is really easy to do, and it will allow us to parallelize not only across test_pr environments but also across test groups in a single iptest run (with some attention paid to the collection of stdout/stderr, obviously, as is always the case with parallelizing console jobs). |
That would be excellent. @bfroehle any interest in doing that here? |
Create a unique & temporary IPYTHONDIR for each testing group. Following #2148 (unification of Windows / Unix code in iptest), and in progress towards #1880 (Add parallelism to iptest & test_pr), this pull request launches each iptest test group with a unique & temporary `IPYTHONDIR`. This has two benefits: * Insulates the test suite from any craziness in your own configuration. (Try adding `import sys; sys.exit()` to your config file...). * Allows multiple test suites to be launched in parallel without the worry of conflicts.
Create a unique & temporary IPYTHONDIR for each testing group. Following ipython#2148 (unification of Windows / Unix code in iptest), and in progress towards ipython#1880 (Add parallelism to iptest & test_pr), this pull request launches each iptest test group with a unique & temporary `IPYTHONDIR`. This has two benefits: * Insulates the test suite from any craziness in your own configuration. (Try adding `import sys; sys.exit()` to your config file...). * Allows multiple test suites to be launched in parallel without the worry of conflicts.
I often have several unused cores sitting around, so it'd be great if the
test_pr
script could allow some parallelism.test_pr
against multiple PRs simultaneously.iptest
scripts in each virtual environment concurrently.The text was updated successfully, but these errors were encountered: