Make ipython cProfile-able #193
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
I know this script is designed to just start ipython from the top-level source dir, but won't this mean that the script will no longer work if curdir is not the top-level source dir? That may be OK though. Can we make it work both ways? |
|
Ha, I found another way (althought, it looks like a hack^^). This works now both ways (but doesn't look nice anymore at least for me). |
When using __file__ on startup and cProfile in the same time, __file__ is defined as the __file__ of cProfile and not the local ipython.py. With using sys.argv[0] instead, it's possible to get a cProfile.
|
This fix does work for me in and out of the directory with ipython.py, but the following has always worked for me: Brian, should I go ahead and merge this? |
|
I haven't testing this, but it looks fine. |
|
Merge branch 'ready_cProfile' of https://github.com/tomspur/ipython closed by 604c8e1 |
markvoorhies
pushed a commit
to markvoorhies/ipython
that referenced
this pull request
Apr 21, 2011
ellisonbg
added a commit
to minrk/ipython
that referenced
this pull request
Jul 1, 2013
Override ipython css for .fade
mattvonrocketstein
pushed a commit
to mattvonrocketstein/ipython
that referenced
this pull request
Nov 3, 2014
This pull request was closed.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
To get a cProfile of ipython inside of the git repo you could run:
"python -m cProfile ipython.py"
Currently file is wrongly detected and it crashes, after this commit, you get a proper cProfile.