New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
frontend test tweaks #1996
frontend test tweaks #1996
Conversation
avoid false-failures due to slow subprocess startup
addresses mismatched comparison when locale cannot handle unicode (e.g. ascii) closes ipython#1589
fixes error when running in ASCII locale
Test results for commit 93f5f3d merged into master
Not available for testing: python3.1 |
The above test_pr was run in an ASCII locale on OS X, which revealed another py3-specific test failure due to ascii default encoding. |
Test results for commit 8c11e5c merged into master
Not available for testing: python2.6, python3.1 |
Speaking of frontend tests, I've been seeing this one recently. It's not causing anything to fail, however...
|
interesting - I've never seen that error, and from the code, it makes no sense at all for it to happen - the event filter is registered after the attribute is assigned. It could be a garbage collection issue on exit, where the event filter is still registered, but the object has started to be deleted. |
The garbage collection hypothesis seems pretty reasonable, given that the |
I wrote, but apparently failed to post, a note about @cdeil's test_pr run: I believe all failures listed are due to libedit, and should not be considered real failures (libedit is fully expected to break all kinds of stuff). I can confirm that an ASCII locale no longer fails (I could reproduce exactly the failures reported in #1589, and they are fixed). Getting virtualenv to install the right readline is a bit of a pain, and I don't quite remember how to do it. |
frontend test tweaks for ASCII locale add some encoding to readline history tests that would fail in casting locales (ascii), so that the expected output really matches what should happen. also relaxes a few timeouts in another test, which were seen to fail while poking around, to avoid spurious failures. closes #1589
frontend test tweaks for ASCII locale add some encoding to readline history tests that would fail in casting locales (ascii), so that the expected output really matches what should happen. also relaxes a few timeouts in another test, which were seen to fail while poking around, to avoid spurious failures. closes ipython#1589
add some encoding to readline history tests that would fail in casting locales (ascii), so that the expected output really matches what should happen.
also relaxes a few timeouts in another test, which were seen to fail while poking around, to avoid spurious failures.
closes #1589