Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Windows: home directory expansion test fails #2019

Closed
jdmarch opened this issue Jun 24, 2012 · 5 comments · Fixed by #2020
Closed

Windows: home directory expansion test fails #2019

jdmarch opened this issue Jun 24, 2012 · 5 comments · Fixed by #2020

Comments

@jdmarch
Copy link

jdmarch commented Jun 24, 2012

$ iptest IPython.utils
.....................................................................................F........SS.....S...S..S..........................
....................................................................................
======================================================================
FAIL: test_get_ipython_dir_7, test home directory expansion on IPYTHONDIR
----------------------------------------------------------------------
Traceback (most recent call last):
  File "c:\Python27\lib\site-packages\nose\case.py", line 197, in runTest
    self.test(*self.arg)
  File "c:\documents and settings\jdm\ipython\IPython\utils\tests\test_path.py", line 293, in test_get_ipython_dir_7
    nt.assert_equal(ipdir, os.path.join(home_dir, 'somewhere'))
AssertionError: u'c:\\Documents and Settings\\JDM\\somewhere' != 'c:/Documents and Settings/JDM\\somewhere'
    "u'c:\\\\Documents and Settings\\\\JDM\\\\somewhere' != 'c:/Documents and Settings/JDM\\\\somewhere'" = '%s != %s' % (safe_repr(u'c
:\\Documents and Settings\\JDM\\somewhere'), safe_repr('c:/Documents and Settings/JDM\\somewhere'))
    "u'c:\\\\Documents and Settings\\\\JDM\\\\somewhere' != 'c:/Documents and Settings/JDM\\\\somewhere'" = self._formatMessage("u'c:\\
\\Documents and Settings\\\\JDM\\\\somewhere' != 'c:/Documents and Settings/JDM\\\\somewhere'", "u'c:\\\\Documents and Settings\\\\JDM\
\\\somewhere' != 'c:/Documents and Settings/JDM\\\\somewhere'")
>>  raise self.failureException("u'c:\\\\Documents and Settings\\\\JDM\\\\somewhere' != 'c:/Documents and Settings/JDM\\\\somewhere'")


----------------------------------------------------------------------                                                                 R
@jdmarch
Copy link
Author

jdmarch commented Jun 24, 2012

Sorry, I'm getting rote here. This is a path separator issue, not a space issue. Re-titling.

@minrk
Copy link
Member

minrk commented Jun 24, 2012

Were you running the test suite in git-bash, by any chance?

@jdmarch
Copy link
Author

jdmarch commented Jun 24, 2012

I was, thanks for catching the omission. The test runs fine in cmd.exe, with or without the PR.

@minrk
Copy link
Member

minrk commented Jun 24, 2012

Ok. I think git-bash sets HOME with unix-style slashes, which causes this weirdness.

@fperez
Copy link
Member

fperez commented Jun 24, 2012

Fix in #2020 looks clean, merging now...

jenshnielsen pushed a commit to jenshnielsen/ipython that referenced this issue Jun 24, 2012
…test_windows

Fix home path expansion test in Windows.

Fixes ipython#2019.
mattvonrocketstein pushed a commit to mattvonrocketstein/ipython that referenced this issue Nov 3, 2014
mattvonrocketstein pushed a commit to mattvonrocketstein/ipython that referenced this issue Nov 3, 2014
…test_windows

Fix home path expansion test in Windows.

Fixes ipython#2019.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants