Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

client doesn't use connection file's 'location' in disambiguating 'interface' #2361

Closed
ikn opened this issue Aug 30, 2012 · 3 comments
Closed

client doesn't use connection file's 'location' in disambiguating 'interface' #2361

ikn opened this issue Aug 30, 2012 · 3 comments
Labels
bug parallel
Milestone
1.0

Comments

@ikn
Copy link
Contributor

ikn commented Aug 30, 2012

be9601b seems to have changed client.py to stop using location in the call to util.disambiguate_ip_address (previously util.disambiguate_url). This means that if interface's address is '*', the client tries to connect to localhost, which doesn't seem to me to be the correct behaviour.

The fix appears to be as simple as

-        addr = util.disambiguate_ip_address(addr)
+        addr = util.disambiguate_ip_address(addr, location)
@minrk
Copy link
Member

minrk commented Aug 30, 2012

Indeed - I caught the same typo in ipengineapp, but missed this one. Want to make a Pull Request?

@ikn
Copy link
Contributor Author

ikn commented Aug 30, 2012

I feel like I should reference it from here or something - #2364.

@minrk minrk closed this as completed in bf94297 Aug 30, 2012
minrk added a commit that referenced this issue Aug 30, 2012
@minrk
Merge pull request #2364 from ikn/client-use-location
ddde2e1 
make clients use 'location' properly (fixes #2361)

closes #2361
@minrk
Copy link
Member

minrk commented Aug 31, 2012

fix merged, thanks!

mattvonrocketstein pushed a commit to mattvonrocketstein/ipython that referenced this issue Nov 3, 2014
@ikn
make clients use 'location' properly (fixes ipython#2361)
236dc6b 
This fixes a previous change that removed the location argument from the
call to util.disambiguate_ip_address, which stops it getting used where
interface is * or 0.0.0.0.
mattvonrocketstein pushed a commit to mattvonrocketstein/ipython that referenced this issue Nov 3, 2014
@minrk
Merge pull request ipython#2364 from ikn/client-use-location
f5d76e3 
make clients use 'location' properly (fixes ipython#2361)

closes ipython#2361
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
bug parallel
Projects
None yet
Milestone
1.0
Development

No branches or pull requests
2 participants
@minrk @ikn