Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

nbviewer bug? with multi-file gists #2483

Closed
ctb opened this issue Oct 12, 2012 · 7 comments
Closed

nbviewer bug? with multi-file gists #2483

ctb opened this issue Oct 12, 2012 · 7 comments
Assignees
Milestone

Comments

@ctb
Copy link

ctb commented Oct 12, 2012

If a multi-file gist has a file whose name does NOT end in ipynb, it cannot be viewed by nbviewer.

Compare:

http://nbviewer.ipython.org/3869768/

specifically

http://nbviewer.ipython.org/3869768/solutions-week5-coinflips.ipynb

and

http://nbviewer.ipython.org/3869768/foo

@fperez
Copy link
Member

fperez commented Oct 12, 2012

@Carreau, thoughts on this one? nbviewer is your baby...

@Carreau
Copy link
Member

Carreau commented Oct 12, 2012

I'm in conference only with my phone. Please assign to me, i'll try to have
a look next week.

Cheers.

Matthias.
Le 12 oct. 2012 05:21, "Fernando Perez" notifications@github.com a écrit :

@Carreau https://github.com/Carreau, thoughts on this one? nbviewer is
your baby...


Reply to this email directly or view it on GitHubhttps://github.com//issues/2483#issuecomment-9365514.

@ghost ghost assigned Carreau Oct 12, 2012
@fperez
Copy link
Member

fperez commented Oct 12, 2012

No worries, enjoy the conference! Thanks :)

@Carreau
Copy link
Member

Carreau commented Oct 13, 2012

For future references, we have a nbviewer repo where issues can be opened.

Non .ipynb files are send as raw. 'Detecting' that a file is a ipynb file is not obvious, and I don't want to write heuristics to guess wether a file should be rendered as ipynb or not.

By rendering non-.ipynb file as raw, then you can have relative url to them in your ipynb files, and wiew then in nbviewer.

I know that notebook server serves files with a /files prefix and I have to deal with that, but it is not easy, and i miss time.

IMHO, multi gist files are not ment to have multi notebooks, but notebook with other resources. For multiple notebook, please have a look as nbviewer-dev.herokuapp.com

@ctb
Copy link
Author

ctb commented Oct 17, 2012

On Sat, Oct 13, 2012 at 04:42:52AM -0700, Bussonnier Matthias wrote:

For future references, we have a nbviewer repo where issues can be opened.

Non .ipynb files are send as raw. 'Detecting' that a file is a ipynb file is not obvious, and I don't want to write heuristics to guess wether a file should be rendered as ipynb or not.

By rendering non-.ipynb file as raw, then you can have relative url to them in your ipynb files, and wiew then in nbviewer.

I know that notebook server serves files with a /files prefix and I have to deal with that, but it is not easy, and i miss time.

IMHO, multi gist files are not ment to have multi notebooks, but notebook with other resources. For multiple notebook, please have a look as nbviewer-dev.herokuapp.com

Hi Matthias,

OK -- just wanted to point out that the multi-gist behavior was triggered
by students who didn't know any better, suggesting that it's not obvious
one way or another :)

best,

--titus

C. Titus Brown, ctb@msu.edu

@minrk
Copy link
Member

minrk commented Jan 20, 2013

I don't think it's unreasonable for the gist shortcut to require properly named files.
The raw url approach does not have this restriction, so you can still view it.

I think this can be closed.

@Carreau
Copy link
Member

Carreau commented Jan 20, 2013

Closing.

@Carreau Carreau closed this as completed Jan 20, 2013
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

4 participants