New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Test failure with FileLinks class on Windows #2732
Comments
OK, thanks for catching this. I'll work on the fix, but don't have a windows box to test on. How is windows testing typically handled for devs who don't have access to a windows machine? |
I don't think we've got a good answer to that question, unfortunately. For simple problems, we tend to commit something that we think should fix it, and then either get someone with Windows to test it, or merge it and wait for a ShiningPanda build. For more complex problems, a dev who does have Windows might step forwards. I think @jstenar is the main Windows user, although several of the other devs have Windows VMs they can test in. |
OK, thanks. I'll work on a fix for this ASAP (in the next day or two). |
@gregcaporaso - just checking for updates on this one - have you had a chance to have a look at it? I might add you to ShiningPanda's email notifications of build failures ;-) |
Sorry, I haven't but will this weekend. |
all occurrences of '/' were replaced with os.sep. This should address issues with broken links on Windows, but I don't have access to a Windows machine to test this. Can someone with a Windows machine please test before merging?
i am still very concerned that I can't test this on windows - I'm not used to developing for windows, so not sure that these links will work even if the test passes on windows. is there a good AWS AMI to use for windows testing? i can run this in my own AWS account.
this should address the failure in #2732
Memo to self: this should be fixed now. If the next Shiningpanda Windows build succeeds, I'll close it. |
It's passing again. Thanks @gregcaporaso. |
Excellent! |
i am still very concerned that I can't test this on windows - I'm not used to developing for windows, so not sure that these links will work even if the test passes on windows. is there a good AWS AMI to use for windows testing? i can run this in my own AWS account.
this should address the failure in ipython#2732
Note that the last slash in the href changes - actual has a forward slash, expected a backslash.
Ping @gregcaporaso, who added those classes.
Example ShiningPanda failure at https://jenkins.shiningpanda.com/ipython/job/ipython-win-py27/lastBuild/console
The text was updated successfully, but these errors were encountered: