Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Test suite should set sqlite history to work in :memory: #308

Closed
fperez opened this issue Mar 25, 2011 · 5 comments
Closed

Test suite should set sqlite history to work in :memory: #308

fperez opened this issue Mar 25, 2011 · 5 comments
Milestone

Comments

@fperez
Copy link
Member

fperez commented Mar 25, 2011

After the merge of the sqlite branch, the test suite got really slow. I've just realized it's because of all the massive amount of disk activity of all the disk writes.

Furthermore, this now means that after a run of the test suite, all history is polluted with all the inputs from the testing.

So the test suite should set the sqlite database to be :memory: instead of an actual file on disk. This will make things both go much faster, and avoid the history pollution problem.

@rkern
Copy link
Contributor

rkern commented Mar 25, 2011

I'm on it. I'm going to do a little refactoring of the HistoryManager.__init__() to use Traitlet _default methods where possible. This will let us replace hist_file=':memory:' more flexibly.

@fperez
Copy link
Member Author

fperez commented Mar 25, 2011

On Fri, Mar 25, 2011 at 8:41 AM, rkern
reply@reply.github.com
wrote:

I'm on it. I'm going to do a little refactoring of the HistoryManager.__init__() to use Traitlet _default methods where possible. This will let us replace hist_file=':memory:' more flexibly.

Awesome, thanks!

@rkern
Copy link
Contributor

rkern commented Mar 25, 2011

#312

I'm not sure how much this really affects the test suite runtime. On my machine, the bulk of the time is taken up by the IPython.kernel test suite.

@fperez
Copy link
Member Author

fperez commented Mar 25, 2011

Hey,

On Fri, Mar 25, 2011 at 9:30 AM, rkern
reply@reply.github.com
wrote:

#312

I'm not sure how much this really affects the test suite runtime. On my machine, the bulk of the time is taken up by the IPython.kernel test suite.

Thanks, I'll have a look in a sec. The point is that the .core test
time went up by a lot (on my laptop with a slow 5400 rpm disk).
.kernel still takes longest, but that stuff will eventually go away,
while .core tests will likely grow, so we were taking a hit in the
wrong place.

Looking at the code now...

f

@fperez
Copy link
Member Author

fperez commented Mar 25, 2011

Cloed by 62118c7.

@fperez fperez closed this as completed Mar 25, 2011
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants