History memory #312
Merged
History memory #312
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…on of the HistoryManager to support this.
|
Awesome, many thanks! The .core test time went from ~30 secs to 2 secs on my machine, so this really is significant. Great job, as always. |
| @@ -47,15 +47,22 @@ class HistoryManager(Configurable): | |||
| input_hist_raw = List([""]) | |||
| # A list of directories visited during session | |||
| dir_hist = List() | |||
| def _dir_hist_default(self): | |||
There was a problem hiding this comment.
Does this method get automatically picked up by traits to set the default?
|
This looks fine to me, but I've been too slow with reviewing it, and it's already merged. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Use a :memory: DB for history during testing.