Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

find_cmd test failure on Windows #3316

Closed
takluyver opened this issue May 14, 2013 · 0 comments · Fixed by #3338
Closed

find_cmd test failure on Windows #3316

takluyver opened this issue May 14, 2013 · 0 comments · Fixed by #3338

Comments

@takluyver
Copy link
Member

I think this is caused by #3301. The Windows implementation of find_cmd expects a command name without an extension, but the test now uses 'python.exe'.

I think that 'python.exe' is a valid command on Windows, so I think we should modify find_cmd to allow passing a command with an extension. Alternatively, we could modify the test to strip the extension.

======================================================================
ERROR: Make sure we find sys.exectable for python.
----------------------------------------------------------------------
Traceback (most recent call last):
  File "S:\Users\slave\Jenkins\shiningpanda\jobs\d5f643a2\virtualenvs\ff035a1d\lib\site-packages\nose\case.py", line 197, in runTest
    self.test(*self.arg)
  File "S:\Users\slave\Jenkins\shiningpanda\jobs\d5f643a2\virtualenvs\ff035a1d\lib\site-packages\ipython-1.0.dev-py2.7.egg\IPython\utils\tests\test_process.py", line 36, in test_find_cmd_python
    nt.assert_equal(find_cmd(python), sys.executable)
  File "S:\Users\slave\Jenkins\shiningpanda\jobs\d5f643a2\virtualenvs\ff035a1d\lib\site-packages\ipython-1.0.dev-py2.7.egg\IPython\utils\process.py", line 67, in find_cmd
    raise FindCmdError('command could not be found: %s' % cmd)
FindCmdError: command could not be found: python.exe
takluyver added a commit to takluyver/ipython that referenced this issue May 18, 2013
minrk added a commit that referenced this issue Jul 15, 2013
closes #3316

According to [documentation here](http://docs.activestate.com/activepython/2.4/pywin32/win32api__SearchPath_meth.html),
SearchPath takes an optional third parameter for the extension,
which is only added if the filename doesn't have an extension.
mattvonrocketstein pushed a commit to mattvonrocketstein/ipython that referenced this issue Nov 3, 2014
mattvonrocketstein pushed a commit to mattvonrocketstein/ipython that referenced this issue Nov 3, 2014
closes ipython#3316

According to [documentation here](http://docs.activestate.com/activepython/2.4/pywin32/win32api__SearchPath_meth.html),
SearchPath takes an optional third parameter for the extension,
which is only added if the filename doesn't have an extension.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant