Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

no warning when leaving/closing notebook on master without saved changes #3475

Closed
ivanov opened this issue Jun 27, 2013 · 1 comment · Fixed by #3478
Closed

no warning when leaving/closing notebook on master without saved changes #3475

ivanov opened this issue Jun 27, 2013 · 1 comment · Fixed by #3478
Labels
Milestone

Comments

@ivanov
Copy link
Member

ivanov commented Jun 27, 2013

I suspect this happened with the bootstrap merge, but haven't verified.

click on URL and/or closing the notebook no longer throws any warning (the way it did in 0.13.2). I know we have checkpointing now, but I have changes that don't get checkpointed that get lost...

Additionally, URL in markdown which used to open new windows (at least as of 0.13.2) not open in the same window.

@minrk
Copy link
Member

minrk commented Jun 27, 2013

Nav away triggers autosave if dirty, but I think it's possible for that request to fail if it takes too long. We should put back the warning to be safe.

minrk added a commit to minrk/ipython that referenced this issue Jun 28, 2013
Autosave is triggered at this event, but it seems to fail sometimes (perhaps when it's too slow?).

closes ipython#3475
mattvonrocketstein pushed a commit to mattvonrocketstein/ipython that referenced this issue Nov 3, 2014
Autosave is triggered at this event, but it seems to fail sometimes (perhaps when it's too slow?).

closes ipython#3475
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants