Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Ending Notebook renaming dialog with return creates new-line #3926

Closed
michaelaye opened this issue Aug 7, 2013 · 1 comment · Fixed by #3929
Closed

Ending Notebook renaming dialog with return creates new-line #3926

michaelaye opened this issue Aug 7, 2013 · 1 comment · Fixed by #3929
Milestone
1.0

Comments

@michaelaye
Copy link
Contributor

The dialog for the renaming of the notebook can be closed via the OK button and a mouse-click or via pressing the Return/Enter key.
When doing the latter, a new-line is introduced in the currently active cell.
Can this be avoided?
Version: 1.0.0a1
minrk added a commit to minrk/ipython that referenced this issue Aug 7, 2013
@minrk
swallow enter event in rename dialog
db53a23 
avoids adding newline in cell after dialog is closed.

closes ipython#3926
@minrk minrk mentioned this issue Aug 7, 2013
Merged
@minrk
Copy link
Member

minrk commented Aug 7, 2013

Try PR #3929

minrk added a commit that referenced this issue Aug 7, 2013
@minrk
Merge pull request #3929 from minrk/rename-cr
3879f00 
swallow enter event in rename dialog

avoids adding newline in cell after dialog is closed.

closes #3926
mattvonrocketstein pushed a commit to mattvonrocketstein/ipython that referenced this issue Nov 3, 2014
@minrk
swallow enter event in rename dialog
7340d93 
avoids adding newline in cell after dialog is closed.

closes ipython#3926
mattvonrocketstein pushed a commit to mattvonrocketstein/ipython that referenced this issue Nov 3, 2014
@minrk
Merge pull request ipython#3929 from minrk/rename-cr
29e65a1 
swallow enter event in rename dialog

avoids adding newline in cell after dialog is closed.

closes ipython#3926
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
1.0
Development

Successfully merging a pull request may close this issue.

swallow enter event in rename dialog minrk/ipython
2 participants
@michaelaye @minrk