Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make ipython-qtconsole a GUI script #422

Merged
merged 2 commits into from May 11, 2011
Merged

Make ipython-qtconsole a GUI script #422

merged 2 commits into from May 11, 2011

Conversation

epatters
Copy link
Contributor

@epatters epatters commented May 9, 2011

The 'ipython-qtconsole' script is now configured as a GUI script in setuptools.

This only really matters on Windows: it ensures that pythonw is used for the script. This is not a big deal for developers but is a good thing to have for the 0.11 release, I think.

@minrk
Copy link
Member

minrk commented May 9, 2011

I see no problem with this other than possibly the copying of find_scripts to find_gui_scripts. Our setup code for finding packages and scripts is ludicrously complicated at this point, resulting in the just about every new package or script not being properly installed under some circumstances for weeks or months after being added. Maybe implement this inside one find_scripts method that returns:

if entry_points:
    return {'console_scripts' : [cscripts], 'gui_scripts' : [gscripts]}}
else:
    return [allscripts]

So we can just do:

setuptools_extra_args['entry_points'] = find_scripts(True)
#...
 setup_args['scripts'] = find_scripts(False)

@epatters
Copy link
Contributor Author

epatters commented May 9, 2011

Yes, that is better. Will do when I get a chance.

@epatters
Copy link
Contributor Author

@minrk
Look good?

@minrk
Copy link
Member

minrk commented May 11, 2011

yes, great. Go ahead and merge.

epatters added a commit that referenced this pull request May 11, 2011
Make ipython-qtconsole a GUI script
@epatters epatters merged commit c2b156d into ipython:master May 11, 2011
mattvonrocketstein pushed a commit to mattvonrocketstein/ipython that referenced this pull request Nov 3, 2014
Make ipython-qtconsole a GUI script
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants