Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Incorrect info in "Messaging in IPython" documentation. #4485

Closed
edechter opened this issue Nov 3, 2013 · 1 comment · Fixed by #4488
Closed

Incorrect info in "Messaging in IPython" documentation. #4485

edechter opened this issue Nov 3, 2013 · 1 comment · Fixed by #4488
Labels
documentation
Milestone
2.0

Comments

@edechter
Copy link

edechter commented Nov 3, 2013

It seems that tab completion in the IPython notebook requires that the complete_reply message have a "matched_text" field. But this is not mentioned in docs/source/development/messaging.rst , or anywhere else.
@Carreau
Copy link
Member

Carreau commented Nov 4, 2013

Seem to be a typo, I guess

# the substring of the matched text
# this is typically the common prefix of the matches,
# and the text that is already in the block that would be replaced by the full completion.
# This would be 'a.is' in the above example.
'text' : str,

Should be matched_text.

Cross linking IHaskell/IHaskell#32

Carreau added a commit to Carreau/ipython that referenced this issue Nov 4, 2013
@Carreau
fix typo in message spec doc
14c60d1 
complete_reply have a `matched_text` and not a `text` field.

Fixes  ipython#4485
@Carreau Carreau mentioned this issue Nov 4, 2013
Merged
minrk added a commit that referenced this issue Dec 24, 2013
@minrk
Backport PR #4488: fix typo in message spec doc
2a903a3 
complete_reply have a `matched_text` and not a `text` field.

Fixes  #4485.

Should we backport doc fixes on 1.x ?
mattvonrocketstein pushed a commit to mattvonrocketstein/ipython that referenced this issue Nov 3, 2014
@Carreau
fix typo in message spec doc
81fade8 
complete_reply have a `matched_text` and not a `text` field.

Fixes  ipython#4485
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
documentation
Projects
None yet
Milestone
2.0
Development

Successfully merging a pull request may close this issue.

fix typo in message spec doc Carreau/ipython
2 participants
@Carreau @edechter