Renaming new notebook to an exist name silently deletes the old one

[herrlich10]

I had a bunch of notebooks corresponding to different analyses under one directory. I then created a new notebook, rename it in the opened tab, saved. Unfortunately, I realized immediately that one of the old notebooks already used that name. Looking at the folder, the old notebook and hours of work seemed to be eternally lost.

Perhaps there could be some warning before overwriting an exist notebook?

Thanks!

[minrk]

Renaming to an existing notebook fails with an informative message in current master. Are you on 1.1?

[herrlich10]

Sorry, but yes, I'm on 1.1.
Glad to know that this is fixed in upcoming version.
Thanks!

I'm not familiar with github. Should I close the issue?

[damianavila]

Probably it is better to merge the solution before closing this one...

[takluyver]

By the sounds of it, the fix was already merged, just not yet released. So I'll close this - we can reopen if there's something still to be done.

[minrk]

Yes, it was fixed, it just wasn't tested - I only added the test verifying that it was already working as intended.