New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Lots of tests fail due to space in sys.executable #4629
Milestone
Comments
takluyver
added a commit
to takluyver/ipython
that referenced
this issue
Dec 3, 2013
Avoids quoting and escaping issues if there is a space in sys.executable. Closes ipythongh-4629
See #4631. |
#4631 fixes the first three error messages above, but not the last one in I will have a go at fixing that one myself! |
Go for it ;-) |
See #4633. |
watercrossing
added a commit
to watercrossing/ipython
that referenced
this issue
Dec 4, 2013
mattvonrocketstein
pushed a commit
to mattvonrocketstein/ipython
that referenced
this issue
Nov 3, 2014
Avoids quoting and escaping issues if there is a space in sys.executable. Closes ipythongh-4629
mattvonrocketstein
pushed a commit
to mattvonrocketstein/ipython
that referenced
this issue
Nov 3, 2014
mattvonrocketstein
pushed a commit
to mattvonrocketstein/ipython
that referenced
this issue
Nov 3, 2014
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
I have just created a virtualenv in my home directory, but unfortunately I have a space in my windows username, so that my home directory sits at
C:\users\Firstname Lastname. This causes a lot of tests to fail.
This is all under Win8.1x64, python2.7.5x64, and ipython's latest master branch.
Here are some fail messages:
It seems to me that the problem is that the problem is this:
https://github.com/ipython/ipython/blob/master/IPython/testing/tools.py#L439 naively assembles the command by doing a " ".join([sys.executable, args]), instead of escaping spaces correctly as described in the subprocess module (http://hg.python.org/cpython/file/tip/Lib/subprocess.py#l622).
However the escaping is different for unix/windows, so it shouldn't really be done here, but it should rather be possible to pass the list of sys.executable and arguments to https://github.com/ipython/ipython/blob/master/IPython/utils/_process_common.py#L42
Regards
The text was updated successfully, but these errors were encountered: