iptest script has 0 exit code even when tests fail #468

Closed
juliantaylor opened this Issue May 24, 2011 · 6 comments

Comments

Projects
None yet
3 participants

the iptest script should have a non-zero (=failure) exit code when tests fail
currently it always returns 0 when executing all test groups

$ LANG=C PATH=$PWD/IPython/scripts/:$PATH PYTHONPATH=$PWD IPython/scripts/iptest
...
ERROR - 1 out of 9 test groups failed.
----------------------------------------
$echo $?
0

when executing only a single test group it does correctly return 1:

 $ LANG=C PATH=$PWD/IPython/scripts/:$PATH PYTHONPATH=$PWD IPython/scripts/iptest IPython.core
 ....
 FAILED (KNOWNFAIL=2, errors=4)
 $ echo $?
 1

takluyver was assigned May 24, 2011

the branch works fine for me

Owner

fperez commented May 25, 2011

@takluyver, go ahead and merge that and close this one, it's the right fix indeed. Thanks!

Owner

takluyver commented May 25, 2011

@fperez: Way ahead of you ;) 465180e

Owner

fperez commented May 25, 2011

OK, but I get to close the bug then ;)

fperez closed this May 25, 2011

Owner

takluyver commented May 25, 2011

Oh yeah, I forgot to put it in the commit message. Thanks, Fernando.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment