Skip to content

HTTPS clone URL

Subversion checkout URL

You can clone with
or
.
Download ZIP

Loading…

iptest script has 0 exit code even when tests fail #468

Closed
juliantaylor opened this Issue · 6 comments

3 participants

@juliantaylor
Collaborator

the iptest script should have a non-zero (=failure) exit code when tests fail
currently it always returns 0 when executing all test groups

$ LANG=C PATH=$PWD/IPython/scripts/:$PATH PYTHONPATH=$PWD IPython/scripts/iptest
...
ERROR - 1 out of 9 test groups failed.
----------------------------------------
$echo $?
0

when executing only a single test group it does correctly return 1:

 $ LANG=C PATH=$PWD/IPython/scripts/:$PATH PYTHONPATH=$PWD IPython/scripts/iptest IPython.core
 ....
 FAILED (KNOWNFAIL=2, errors=4)
 $ echo $?
 1
@takluyver takluyver was assigned
@juliantaylor
Collaborator

the branch works fine for me

@fperez
Owner

@takluyver, go ahead and merge that and close this one, it's the right fix indeed. Thanks!

@takluyver
Owner

@fperez: Way ahead of you ;) 465180e

@fperez
Owner

OK, but I get to close the bug then ;)

@fperez fperez closed this
@takluyver
Owner

Oh yeah, I forgot to put it in the commit message. Thanks, Fernando.

@damianavila damianavila referenced this issue from a commit
Commit has since been removed from the repository and is no longer available.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Something went wrong with that request. Please try again.