New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

iptest script has 0 exit code even when tests fail #468

Closed
juliantaylor opened this Issue May 24, 2011 · 6 comments

Comments

Projects
None yet
3 participants
@juliantaylor
Contributor

juliantaylor commented May 24, 2011

the iptest script should have a non-zero (=failure) exit code when tests fail
currently it always returns 0 when executing all test groups

$ LANG=C PATH=$PWD/IPython/scripts/:$PATH PYTHONPATH=$PWD IPython/scripts/iptest
...
ERROR - 1 out of 9 test groups failed.
----------------------------------------
$echo $?
0

when executing only a single test group it does correctly return 1:

 $ LANG=C PATH=$PWD/IPython/scripts/:$PATH PYTHONPATH=$PWD IPython/scripts/iptest IPython.core
 ....
 FAILED (KNOWNFAIL=2, errors=4)
 $ echo $?
 1

@ghost ghost assigned takluyver May 24, 2011

@takluyver

This comment has been minimized.

Member

takluyver commented May 24, 2011

@juliantaylor

This comment has been minimized.

Contributor

juliantaylor commented May 24, 2011

the branch works fine for me

@fperez

This comment has been minimized.

Member

fperez commented May 25, 2011

@takluyver, go ahead and merge that and close this one, it's the right fix indeed. Thanks!

@takluyver

This comment has been minimized.

Member

takluyver commented May 25, 2011

@fperez: Way ahead of you ;) 465180e

@fperez

This comment has been minimized.

Member

fperez commented May 25, 2011

OK, but I get to close the bug then ;)

@fperez fperez closed this May 25, 2011

@takluyver

This comment has been minimized.

Member

takluyver commented May 25, 2011

Oh yeah, I forgot to put it in the commit message. Thanks, Fernando.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment