Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Completer As-You-Type Broken #4860

Closed
Carreau opened this issue Jan 24, 2014 · 6 comments · Fixed by #5112
Closed

Completer As-You-Type Broken #4860

Carreau opened this issue Jan 24, 2014 · 6 comments · Fixed by #5112

Comments

@Carreau
Copy link
Member

Carreau commented Jan 24, 2014

Completer does not seem to pick/filter when you type.

keypress seem not to be forwarded to codemirror.

@ellisonbg
Copy link
Member

@Carreau I am really stumped on this one. The issue is that when the completer opens, we focus the selection area of the completer and handle keyboard events with Completer.keydown. Because the completer is attached to the body, the keyboard events never reach that CodeMirror instance to allow the user to keep typing. I don't see how it is possible to 1) keep the CM editor focused so the user can type and 2) keep the completer Ui focused so its own keyboard shortcuts work. How did this ever work in the first place?

@ghost ghost assigned Carreau Jan 30, 2014
@Carreau
Copy link
Member Author

Carreau commented Jan 30, 2014

Hi Brian, Sorry I have lots of difficulties to follow theses days with 400 Mails when I wakes Up+PhD, so If I don't respond to some of your pings, it's not against you.

IIRC, the trick was to forward all event (except arrow keys) to codemirror explicitely, after IIRC codemirror re-call the completer automatically.

I try to have a look, but I can't promise you I will even be at the dev meeting in ~10 hours.

@ellisonbg
Copy link
Member

LOL, yes, the amount of activity right now is a bit crazy, I can't step
away for a few minutes before I am flooded. 44 PRs closed this week so far
:)

Thanks...

On Thu, Jan 30, 2014 at 12:01 AM, Matthias Bussonnier <
notifications@github.com> wrote:

Hi Brian, Sorry I have lots of difficulties to follow theses days with 400
Mails when I wakes Up+PhD, so If I don't respond to some of your pings,
it's not against you.

IIRC, the trick was to forward all event (except arrow keys) to codemirror
explicitely, after IIRC codemirror re-call the completer automatically.

I try to have a look, but I can't promise you I will even be at the dev
meeting in ~10 hours.

Reply to this email directly or view it on GitHubhttps://github.com//issues/4860#issuecomment-33667037
.

Brian E. Granger
Cal Poly State University, San Luis Obispo
bgranger@calpoly.edu and ellisonbg@gmail.com

@Carreau
Copy link
Member Author

Carreau commented Jan 31, 2014

Ok, so I'm.... confused. I can't even have it to work on 1.1 anymore....

I'll try to reimplement using Cm addons that does that this week-end.

@ellisonbg
Copy link
Member

OK this makes me feel better :) Thanks!

On Fri, Jan 31, 2014 at 2:52 AM, Matthias Bussonnier <
notifications@github.com> wrote:

Ok, so I'm.... confused. I can't even have it to work on 1.1 anymore....

I'll try to reimplement using Cm addons that does that this week-end.

Reply to this email directly or view it on GitHubhttps://github.com//issues/4860#issuecomment-33776754
.

Brian E. Granger
Cal Poly State University, San Luis Obispo
bgranger@calpoly.edu and ellisonbg@gmail.com

@Carreau
Copy link
Member Author

Carreau commented Feb 9, 2014

One can try to base it work on #4988 if needed.

fperez added a commit that referenced this issue Feb 22, 2014
Band-aid for completion in the notebook: not the ideal solution, but will have to do the job for now so that typing while completing works.

closes #4860
mattvonrocketstein pushed a commit to mattvonrocketstein/ipython that referenced this issue Nov 3, 2014
Band-aid for completion in the notebook: not the ideal solution, but will have to do the job for now so that typing while completing works.

closes ipython#4860
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants