Cannot align widgets horizontally in the notebook

[rossant]

The HBox container widget does not seem to align children horizontally. For example, here is a screenshot of part 5 of widget tutorial on my local machine.

Tested on latest IPython master: FF, Chrome, IE.

[ellisonbg]

Can you retry with latest master (changes last night) and a cleared browser cache?

Sent from my iPhone

On Feb 8, 2014, at 6:17 AM, Cyrille Rossant notifications@github.com wrote:

The HBox container widget does not seem to align children horizontally. For example, here is a screenshot of part 5 of widget tutorial on my local machine.

Tested on latest FF, Chrome, IE.

—
Reply to this email directly or view it on GitHub.

[rossant]

Can you retry with latest master (changes last night) and a cleared browser cache?

Same problem (tried with Opera too).

[jdfreder]

There are two problems here,

• The vbox class which now exists on all widgets by default isn't being removed in the example notebook code (that notebook needs to be updated).
• We still don't have the new flex model working exactly how the old one did. I'm looking into this right now.

[ellisonbg]

Thanks @jdfreder. There might also be other places we need to check how the new box model is working. Why don't you do a search for hbox and vbox in the JS/less code and check the visual results of those areas to make sure all is OK.

[jdfreder]

Will do- also I've written a notebook that tests the new flex model vs the old model. There were lots of misuses of the new model on my behalf that I have fixed. I will upload the notebook along with the PR that fixes the problems.

[ellisonbg]

Awesome, why don't you put the test notebook in examples/tests.

[rossant]

OK so now it works on master. The only thing is that I need to do

container.remove_class('vbox')
container.add_class('hbox')

Doing just

container.add_class('hbox')

doesn't work.

[jdfreder]

OK so now it works on master.

Fixed by #5075, but not closed. Closing here...

Doing just ... doesn't work.

It's an unfortunate side effect of telling everyone to use CSS to configure alignment. There used to be helper properties that automatically managed this state. During the bi-annual development meeting at UCB it was decided to remove the helper properties. Sorry :( If you'd like, I can open a feature request issue to add these properties back.

[ellisonbg]

I think for now we should keep with the pure css approach and gather more
data.

On Wed, Feb 12, 2014 at 4:47 PM, Jonathan Frederic <notifications@github.com

wrote:

OK so now it works on master.

Fixed by #5075 #5075, but not
closed. Closing here...

Doing just ... doesn't work.

It's an unfortunate side effect of telling everyone to use CSS to
configure alignment. There used to be helper properties that automatically
managed this state. During the bi-annual development meeting at UCB it was
decided to remove the helper properties. Sorry :( If you'd like, I can open
a feature request issue to add these properties back.

Reply to this email directly or view it on GitHubhttps://github.com//issues/5073#issuecomment-34936839
.

Brian E. Granger
Cal Poly State University, San Luis Obispo
bgranger@calpoly.edu and ellisonbg@gmail.com

[jasongrout]

It does seem that in implementing other frontends (like perhaps an android frontend using native widgets), it would be helpful to have the packing direction be an attribute of the widget rather than a side-effect of a class.

[rossant]

I think it's fine as it is now. It's just a matter of documenting properly.