[CSS?] Inconsistencies in nbconvert divs and IPython Notebook divs?

[ahmadia]

I'm working with some custom css used by Lorena Barba's group for her AeroPython notebooks. The recent nbviewer bump just borked our layouts. Looking through the HTML being generated by the live Notebook and nbviewer, I'm seeing inconsistencies in the way the cells are being classified by the engines.

In IPython Notebook master, there's a structure like:

(text cell)
<div class ="cell text_cell ...">
(code cell)
<div class="cell code_cell ...">

Output from nbconvert, on the other hand, looks like:

(text cell)
<div class="input">
(code cell)
<div class="cell border-box-sizing code_cell">
-> <div class="input">

I'll be the first to admit, I'm not great at CSS, but this seems incredibly inconsistent to me. Why use input at the top level of nbconvert? Shouldn't that be cell text_cell or cell text_cell_render to be consistent with the rest of the notebook which in turn contain elements of class input?

What am I misunderstanding here? Here's Lorena's current custom.css, which looks terrible on the recent nbviewer because text cells are not being styled.

Release nbconvert in 1.1 appears to generate something like:

(text cell)
<div class ="text_cell_render ...">
(code cell)
<div class="cell code_cell ...">

Which is at least more consistent. I'm wondering why we aren't at least flagging text cells as the generic cell class. Trying to figure out the CSS on the generated HTML is giving me a headache :(

[rgbkrk]

I'm noticing more and more this morning. In particular, @CamDavidsonPilon's book http://nbviewer.ipython.org/github/CamDavidsonPilon/Probabilistic-Programming-and-Bayesian-Methods-for-Hackers/blob/master/Chapter1_Introduction/Chapter1_Introduction.ipynb and @ptwobrussell's http://nbviewer.ipython.org/github/ptwobrussell/Mining-the-Social-Web-2nd-Edition/blob/master/ipynb/__Understanding%20the%20Reaction%20to%20Amazon%20Prime%20Air.ipynb.

[minrk]

I think this is just a bug in nbconvert - the class structure should match the live notebook.

[ahmadia]

For those following along at home, I guess most of the nbconvert to HTML element class hierarchy happen here:

IPython/nbconvert/templates/html/basic.tpl

I'm going to try a hand at gently refactoring that to look more like the live notebook element class hierarchy and submit a PR, but I'm suspecting one of the core devs will need to write the final PR, since I am not very familiar with this code :/

[minrk]

closed by #5212