display any output from this session in terminal console #5253
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rather than filtering based on the most recent msg_id. avoids excluding async output displayed after status=idle closes ipython#5251
|
I think this looks fine, but we should wait to get feedback from the Julia folks. |
|
An alternative we could add in the future is a threaded approach, where async output would really behave the same in the terminal (messing with the prompt and everything). |
| @@ -222,26 +223,22 @@ def handle_execute_reply(self, msg_id, timeout=None): | |||
| self.execution_count = int(content["execution_count"] + 1) | |||
|
|
|||
|
|
|||
| def handle_iopub(self, msg_id): | |||
| """ Method to process subscribe channel's messages | |||
| def handle_iopub(self, msg_id=''): | |||
There was a problem hiding this comment.
Is the msg_id parameter still used at all. Do we want to remove/deprecate it?
There was a problem hiding this comment.
I don't think it is right now, but I can imagine it being useful. I'll leave it for now.
minrk
added a commit
that referenced
this pull request
Mar 7, 2014
display any output from this session in terminal console
mattvonrocketstein
pushed a commit
to mattvonrocketstein/ipython
that referenced
this pull request
Nov 3, 2014
display any output from this session in terminal console
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
rather than filtering based on the most recent msg_id.
avoids excluding async output displayed after status=idle
closes #5251