ZMQ displayhook #527
Merged
ZMQ displayhook #527
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
This makes sense. But you did move |
|
Thanks, Min. I've added an import there. |
|
Rebased now that newapp is merged. |
|
This makes sense, and I don't see a problem. Go ahead and merge, then. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Move displayhook for ZMQ shell to zmq.displayhook, and rename to make the difference clearer.
Straightforward tidying up. Because I went looking for the displayhook used by ZMQInteractiveShell, and spent a while changing the wrong one before I worked out that it was in zmqshell.py. This puts them both in zmq.displayhook, and attempts to clarify the difference.
See #512