Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Windows had a variety of mostly path-related test failures remaining. With these changes, I have zero failures or errors when I run the test suite on my Windows 7 VM (64b Python 2.7.1).
Most of these were Windows-excluding assumptions in the tests themselves. The one change to the code itself is stripping quotation marks on Windows in
magic_cd
.os.chdir
doesn't seem to like the quotes on Windows in some cases.Absolute-path completions are now listed as a Known Failure on Windows. A local-path test that is a copy but wrapped in a cd so the prefix is './foo' instead of 'C:...\foo' shows that the completion does work for relative paths.