Getcwdu #574
Merged
Getcwdu #574
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
This pull request relates to issue #569 |
|
Does this actually fix #569, or not? |
|
Merging this now, but let me know if #569 should be closed. |
minrk
added a commit
that referenced
this pull request
Jul 13, 2011
always use getcwdu instead of getcwd
|
This fixes the problem in #569. |
mattvonrocketstein
pushed a commit
to mattvonrocketstein/ipython
that referenced
this pull request
Nov 3, 2014
always use getcwdu instead of getcwd
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Branch to change usage of getcwd into getcwdu.
I did not change the usage of getcwd in core/prompts.py. Because Itpl templates are used there and it appears they do not work well with unicode and takluyver said he is working on replacing Itpl with the builtin templates.
/Jörgen