-
-
Notifications
You must be signed in to change notification settings - Fork 4.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
check_security_dir() and check_pid_dir() fail on network filesystem #773
Comments
Thanks, it should be easy to fallback on a warning if the permissions can't be secure. Does the mkdir also fail, or just chmod? I assume it is an IOError? |
The output was (error message is in German):
It says the file (directory) could not be found, allthough it's existing:
|
In your patch, I had to change IOError to WindowsError, but it complains about the missing log attribute:
|
Silly first attempt - it should be OSError (WindowsError subclasses this), not IOError, and the log attribute has been fixed. It's very strange that the error claims that it can't be found, since the chmod is only attempted if os.path.isdir(loc) returns True. Still, it should now just log and ignore the error, rather than crashing. |
With your changes, I get the following output:
The exeception is complaining about u'n:\ipython\profile_default\security' but that's the Unicode Python value as far as I understand. Shouldn't the normal string representation of the value be used for chmod() ? |
…ws). Also make ProfileDir a LoggingConfigurable, so it can log the new message closes ipythongh-773
For testing purposes and quick setup, I use SSHFS as a simple network filesystem. On Linux and Mac OSX there is FUSE SSHFS available. On Windows there's Dokan SSHFS.
I use SSHFS because Samba and NFS share were leading to incorrect uid/gid mapping. At least for Mac OSX and Ubuntu is was possble to avoid these problems by using SSHFS.
When starting ipengine on Windows, IPython executes check_security_dir() and check_pid_dir() which both try to set the permissions using chmod to 0700. This fails in my setup. After commenting out the offending lines in core/profiledir.py ipengine works.
It would be nice to be able to configure the permission setup.
The text was updated successfully, but these errors were encountered: