Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Notebook should be saved before downloading #852

Closed
fperez opened this issue Oct 10, 2011 · 4 comments
Closed

Notebook should be saved before downloading #852

fperez opened this issue Oct 10, 2011 · 4 comments
Labels
bug notebook
Milestone
2.0

Comments

@fperez
Copy link
Member

fperez commented Oct 10, 2011

If a user works in a new notebook and clicks 'Download' without first having saved anything, they get an empty notebook. We should either prompt to save, or automatically produce a save action, since otherwise it's pretty confusing. Reported by @jdh2358.
minrk added a commit to minrk/ipython that referenced this issue Oct 18, 2011
@minrk
notebook download implies save
2aacd8b 
closes ipython#852
@minrk minrk mentioned this issue Oct 18, 2011
Closed
minrk added a commit that referenced this issue Oct 20, 2011
@minrk
Add tooltip to Download/Print indicating need to save first
bbc4d01 
A real fix would be to trigger a save on each of thes actions, which would address #852

closes gh-895
@fperez
Copy link
Member Author

fperez commented Dec 6, 2011

@minrk, we never merged 2aacd8b b/c it triggered popup warnings, right? We may have to bump this to 0.13 though, we're getting too close to release time...

@minrk
Copy link
Member

minrk commented Dec 6, 2011

Right - I don't know a better way to do this. I'm fine pushing to 0.13.

@fperez
Copy link
Member Author

fperez commented Dec 6, 2011

Sounds good. Triage, triage...

@ellisonbg
Copy link
Member

What is the status of this? Is there an active PR related to it?

@minrk minrk mentioned this issue Oct 12, 2012
Closed
minrk added a commit that referenced this issue Oct 8, 2013
@minrk
save before download-as
686ac33 
uses `async : false`

closes #852

download-as-py still unavailable.
minrk added a commit that referenced this issue Oct 8, 2013
@minrk
save before download-as
a0631a3 
uses `async : false`

closes #852

download-as-py still unavailable.
@minrk minrk closed this as completed in bf72d2f Oct 23, 2013
mattvonrocketstein pushed a commit to mattvonrocketstein/ipython that referenced this issue Nov 3, 2014
@minrk
Add tooltip to Download/Print indicating need to save first
7e95cdc 
A real fix would be to trigger a save on each of thes actions, which would address ipython#852

closes ipythongh-895
mattvonrocketstein pushed a commit to mattvonrocketstein/ipython that referenced this issue Nov 3, 2014
@minrk
save before download-as
aa8a1b3 
uses `async : false`

closes ipython#852

download-as-py still unavailable.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
bug notebook
Projects
None yet
Milestone
2.0
Development

Successfully merging a pull request may close this issue.

notebook download implies save minrk/ipython
3 participants
@ellisonbg @fperez @minrk