promote aliases and flags, to ensure they have priority over config files #855
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…iles add Application.flatten_flags() method, which adjusts the alias and flag dicts, such that they point to the subclass in the Application.classes list when passed to the argv parser. This prevents TerminalInteractiveShell.colors in a config file overriding `--colors` on the command-line, which points to InteractiveShell.colors. Flattening is only done when the answer is unambiguous, so multiply inherited classes (e.g. Launchers in ipcluster) are not touched. also remove now-obsolete manual workaround for this in IPClusterStart closes ipythongh-849
|
Great, thanks! Merged with rebase to avoid recursive merge for just one commit, closing. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
See #849
adds
Application.flatten_flags()method, which adjusts the aliasand flag dicts, such that they point to the subclass in the Application.classes list when passed to the argv parser.
This prevents
TerminalInteractiveShell.colorsin a config file overriding--colorson the command-line, which points toInteractiveShell.colors.Flattening is only done when the answer is unambiguous, so multiply inherited classes (e.g. Launchers in ipcluster) are not touched.
also removes now-obsolete manual workaround for exactly this in IPClusterStart
closes gh-849