Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

- There is a bug when running the profiler in the magic command (prun) with python3 #901

Closed
wants to merge 1 commit into from

Conversation

alcidesv
Copy link

%run -p <...> . And this is an attempt to solve it.

I'm not sure if this is the correct way to handle it.

Regards.

    %run -p <...> . And this is an attempt to solve it.
@alcidesv
Copy link
Author

Oh, I didn't notice this is the wrong repos! My apologies!

@alcidesv alcidesv closed this Oct 19, 2011
@takluyver takluyver reopened this Oct 19, 2011
@takluyver
Copy link
Member

It's OK, this actually is the right place for it now. After 0.11, we merged the Python 3 support in, so this code (which will become 0.12) should now install on Python 2 or Python 3.

I think this looks like a pretty sound approach.

@fperez
Copy link
Member

fperez commented Oct 19, 2011

@takluyver, I'll leave it up to you to review/merge this one, since it's on the py3 territory. Let me know if you want a 2nd look on anything. @Dsign, thanks for the contribution!

@takluyver
Copy link
Member

It looks fine, I'm just going to run a few tests before I merge it. Actually, it's probably a good candidate for adding an automated test. @Dsign, do you want to do that? Have a look in IPython/core/tests/test_run.py. It needn't be complex, just check that doing %run -p succeeds.

@alcidesv
Copy link
Author

No problem, I will take care of it.

@takluyver
Copy link
Member

Great, thanks.

@alcidesv
Copy link
Author

Any hints as how to run a particular case in the test suite? The full test runs more or less o,k, but for individual tests I keep getting something about

global name 'get_ipython' is not defined

thanks in advance.

@alcidesv alcidesv closed this Oct 20, 2011
@takluyver takluyver reopened this Oct 20, 2011
@takluyver
Copy link
Member

Yes, there's some awkward trickery we do to inject get_ipython into the builtin namespace for the test suite. There's a way to specify it in the options to iptest, something like iptest IPython.core.tests.test_run:test_run_p. I normally just specify the package: iptest IPython.core, which takes a few seconds to run the tests.

@fperez
Copy link
Member

fperez commented Oct 21, 2011

@alcidesv
Copy link
Author

Please follow up on:

#916

I had deleted the original branch :-(

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants