New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
- There is a bug when running the profiler in the magic command (prun) with python3 #901
Conversation
%run -p <...> . And this is an attempt to solve it.
Oh, I didn't notice this is the wrong repos! My apologies! |
It's OK, this actually is the right place for it now. After 0.11, we merged the Python 3 support in, so this code (which will become 0.12) should now install on Python 2 or Python 3. I think this looks like a pretty sound approach. |
@takluyver, I'll leave it up to you to review/merge this one, since it's on the py3 territory. Let me know if you want a 2nd look on anything. @Dsign, thanks for the contribution! |
It looks fine, I'm just going to run a few tests before I merge it. Actually, it's probably a good candidate for adding an automated test. @Dsign, do you want to do that? Have a look in |
No problem, I will take care of it. |
Great, thanks. |
Any hints as how to run a particular case in the test suite? The full test runs more or less o,k, but for individual tests I keep getting something about
thanks in advance. |
Yes, there's some awkward trickery we do to inject |
For more details on how to run the test suite: http://ipython.org/ipython-doc/dev/development/testing.html#for-the-impatient-running-the-tests |
Please follow up on: I had deleted the original branch :-( |
I'm not sure if this is the correct way to handle it.
Regards.