Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

ipython crashes on startup if readline is missing #911

Closed
jstenar opened this issue Oct 20, 2011 · 2 comments
Closed

ipython crashes on startup if readline is missing #911

jstenar opened this issue Oct 20, 2011 · 2 comments
Labels
bug important
Milestone
0.12

Comments

@jstenar
Copy link
Member

jstenar commented Oct 20, 2011

See log on https://gist.github.com/1302023
@takluyver
Copy link
Member

@juliantaylor: I think this is from your work enabling multiline history. Do you have time to have a look at it?

@juliantaylor
Copy link
Contributor

there are a couple if self.has_readlines missing :/

alternative would be to move all the multiline history stuff into a the store_rl_history function with before_cell length a class member
Is probably cleaner than sprinkling the code with conditions

juliantaylor added a commit to juliantaylor/ipython that referenced this issue Oct 20, 2011
@juliantaylor
move hlen_before_cell into _replace_rlhist_multiline
e686606 
make hlen_before_cell a class member and move all multiline
history functionality into _replace_rlhist_multiline.
Closes ipythongh-911
@juliantaylor juliantaylor mentioned this issue Oct 25, 2011
Merged
@minrk minrk mentioned this issue Nov 2, 2011
Closed
@minrk minrk closed this as completed in 7c0ffa5 Nov 7, 2011
mattvonrocketstein pushed a commit to mattvonrocketstein/ipython that referenced this issue Nov 3, 2014
@juliantaylor
move hlen_before_cell into _replace_rlhist_multiline
5952c54 
make hlen_before_cell a class member and move all multiline
history functionality into _replace_rlhist_multiline.
Closes ipythongh-911
mattvonrocketstein pushed a commit to mattvonrocketstein/ipython that referenced this issue Nov 3, 2014
@minrk
Merge pull request ipython#929 from juliantaylor/multiline-history
6064c15 
some readline multiline-history fixes and tests

* fixes crash when readline is absent (ipython#911)
* do not save input from e.g. raw_input in history
* do not add empty or duplicate entries lines to the history.
* add tests for _replace_rlhist_multiline
* protect pyreadline from some incorrect assumptions of equivalence to regular readline

closes ipythongh-911
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
bug important
Projects
None yet
Milestone
0.12
Development

No branches or pull requests
4 participants
@minrk @jstenar @takluyver @juliantaylor