Skip to content

Loading…

ipython crashes on startup if readline is missing #911

Closed
jstenar opened this Issue · 2 comments

4 participants

@jstenar
IPython member
@takluyver
IPython member

@juliantaylor: I think this is from your work enabling multiline history. Do you have time to have a look at it?

@juliantaylor

there are a couple if self.has_readlines missing :/

alternative would be to move all the multiline history stuff into a the store_rl_history function with before_cell length a class member
Is probably cleaner than sprinkling the code with conditions

@juliantaylor juliantaylor added a commit to juliantaylor/ipython that referenced this issue
@juliantaylor juliantaylor move hlen_before_cell into _replace_rlhist_multiline
make hlen_before_cell a class member and move all multiline
history functionality into _replace_rlhist_multiline.
Closes gh-911
e686606
@minrk minrk closed this in 7c0ffa5
@mattvonrocketstein mattvonrocketstein pushed a commit to mattvonrocketstein/ipython that referenced this issue
@juliantaylor juliantaylor move hlen_before_cell into _replace_rlhist_multiline
make hlen_before_cell a class member and move all multiline
history functionality into _replace_rlhist_multiline.
Closes gh-911
5952c54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Something went wrong with that request. Please try again.