ipython crashes on startup if readline is missing #911

Closed
jstenar opened this Issue Oct 20, 2011 · 2 comments

Comments

Projects
None yet
4 participants
@takluyver

This comment has been minimized.

Show comment
Hide comment
@takluyver

takluyver Oct 20, 2011

Member

@juliantaylor: I think this is from your work enabling multiline history. Do you have time to have a look at it?

Member

takluyver commented Oct 20, 2011

@juliantaylor: I think this is from your work enabling multiline history. Do you have time to have a look at it?

@juliantaylor

This comment has been minimized.

Show comment
Hide comment
@juliantaylor

juliantaylor Oct 20, 2011

Contributor

there are a couple if self.has_readlines missing :/

alternative would be to move all the multiline history stuff into a the store_rl_history function with before_cell length a class member
Is probably cleaner than sprinkling the code with conditions

Contributor

juliantaylor commented Oct 20, 2011

there are a couple if self.has_readlines missing :/

alternative would be to move all the multiline history stuff into a the store_rl_history function with before_cell length a class member
Is probably cleaner than sprinkling the code with conditions

juliantaylor added a commit to juliantaylor/ipython that referenced this issue Oct 20, 2011

move hlen_before_cell into _replace_rlhist_multiline
make hlen_before_cell a class member and move all multiline
history functionality into _replace_rlhist_multiline.
Closes gh-911

@minrk minrk closed this in 7c0ffa5 Nov 7, 2011

mattvonrocketstein pushed a commit to mattvonrocketstein/ipython that referenced this issue Nov 3, 2014

move hlen_before_cell into _replace_rlhist_multiline
make hlen_before_cell a class member and move all multiline
history functionality into _replace_rlhist_multiline.
Closes gh-911

mattvonrocketstein pushed a commit to mattvonrocketstein/ipython that referenced this issue Nov 3, 2014

Merge pull request #929 from juliantaylor/multiline-history
some readline multiline-history fixes and tests

* fixes crash when readline is absent (#911)
* do not save input from e.g. raw_input in history
* do not add empty or duplicate entries lines to the history.
* add tests for _replace_rlhist_multiline
* protect pyreadline from some incorrect assumptions of equivalence to regular readline

closes gh-911
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment