Fix detection of complete input with line continuations inside a multiline string #10157
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
can you rebase/repush. Travis is unhappy because GitHub was showing unicorns, and refuse to get restarted. |
|
Rebased, Travis is happy now. Appveyor's still going, but as it doesn't run the tests, we're basically just heating up someone's datacentre there. |
|
Do you want to attempt a backport ? |
|
Let's have a go! @meeseeksdev backport to 5.x |
lumberbot-app bot
pushed a commit
that referenced
this pull request
Jan 13, 2017
…ations inside a multiline string I thought that tokenize accepted multiple lines of input as a single 'line' from the readline callback, and it does in most cases, but in this case the behaviour makes a difference. Closes 9841. Alternative to 9899.
Carreau
added a commit
that referenced
this pull request
Jan 14, 2017
Backport PR #10157 on branch 5.x
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I thought that tokenize accepted multiple lines of input as a single 'line' from the readline callback, and it does in most cases, but in this case the behaviour makes a difference.
Closes #9841.
Alternative to #9899.