Minor improvements to completion #10350
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Here is how it looks like not using jedi:
It does not affect completions that much when jedi is installed as jedi mostly returns all the completions that IPython finds with the right text:
the cc @anntzer |
|
Works for me, thanks. |
takluyver
reviewed
Feb 28, 2017
IPython/terminal/ptutils.py
Outdated
| @@ -21,6 +21,23 @@ | |||
|
|
|||
| _completion_sentinel = object() | |||
|
|
|||
| def _ellide(string, *, min_ellide=30): | |||
There was a problem hiding this comment.
It's elide with one L.
However, ellipsis (plural ellipses) with two Ls is correct. English, such a wonderfully consistent language ;-)
If object being completed is a function, append `()` to match the convention used in cpython doc. This include methods. Append `()` only in the _displayed_ menu, does not insert the (). If completion is relatively to long (mostly if is does not come from jedi), and use a fully qualified name with more than 3 parts, ellides the middles one to `…`. (This closes ipython#9835).
Carreau
force-pushed
the
minor-completion-update
branch
from
cb74f51
to
ca19ba9
Compare
Fixed. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
If object being completed is a function, append
()to match theconvention used in cpython doc. This include methods. Append
()onlyin the displayed menu, does not insert the ().
If completion is relatively to long (mostly if is does not come from
jedi), and use a fully qualified name with more than 3 parts, ellides
the middles one to
…. (This closes #9835).