[WIP] cleanup getargspec #11733
Draft
[WIP] cleanup getargspec #11733
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
getargspec is likely going to be removed one of those days in CPython (deprecation has been delayed a couple of times.
It would be nice to remove this from IPython, though it may affect the Jupyter
inspect_reply, as it removesargspecfrom it. Though I could not find anything actually using the info in'argspec'One should study the effect of this patch , if more could be removed, or replaced by using
inspect.signature()Feel free to take over this Patch/PR, I don't have a particular intention of moving it forward soon.