Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Prevent caching outputs in _, __, ___ when cache_size isn't positive #11877

Merged
merged 1 commit into from
Oct 22, 2019

Conversation

mohammad7t
Copy link
Contributor

Fixes #3452 as suggested by @takluyver on #3452 (comment)

@mohammad7t mohammad7t changed the title Prevent caching outputs in _, __, ___ when not self.cache_size Prevent caching outputs in _, __, ___ when cache_size is not activate Sep 5, 2019
@mohammad7t mohammad7t changed the title Prevent caching outputs in _, __, ___ when cache_size is not activate Prevent caching outputs in _, __, ___ when cache_size isn't positive Sep 5, 2019
@Carreau Carreau added this to the 7.9 milestone Oct 22, 2019
@Carreau
Copy link
Member

Carreau commented Oct 22, 2019

Seem reasonable to me. Thanks for your patience.

@Carreau Carreau merged commit 6e490df into ipython:master Oct 22, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Memory leak even when cache_size = 0 and history_length = 0 or history_length = 1
2 participants