New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add 'quiet' option to suppress screen output during %prun calls, edited dochelp #1210
Closed
+34
−31
Closed
Changes from 2 commits
Commits
Show all changes
4 commits
Select commit
Hold shift + click to select a range
41c6b1d
Edited magic_prun() to take a new arguement (-q) to supress screen ou…
andrewgiessel 25d1acd
Small grammar/formatting fix.
andrewgiessel 4dda8cd
Changed all dict.has_key(key) to if key in dict.keys()
andrewgiessel c2a25ef
Typos
andrewgiessel File filter
Filter by extension
Conversations
Failed to load comments.
Jump to
Jump to file
Failed to load files.
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The has_key method is deprecated - we should use
if 'q' not in opts
instead.There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Changing it to if not 'q' in opts is fine by me- i initially coded it like
this, and then noticed that the 'r' option is parsed like this, so I
changed it to match. We should probably change both.
I can double check and look for extraneous whitespace.
What is the best way to proceed? (I'm new to this- first contrib!) Do I
recommit and then do another pull request?
cheers,
ag
On Tue, Dec 27, 2011 at 07:23, Thomas <
reply@reply.github.com
Andrew Giessel, PhD
Department of Neurobiology, Harvard Medical School
220 Longwood Ave Boston, MA 02115
ph: 617.432.7971 email: andrew_giessel@hms.harvard.edu
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Yes, some of the older code was written like that, and hasn't been updated. We're slowly updating it as we revisit it.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hmm, missed your question. Just add another commit after this one, and push it to the same branch (we usually make a feature branch, rather than working on master). The pull request automatically updates when you add commits.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
You don't need to make a new PR - any changes to the branch associated with this PR (master) will be reflected here. You can even remove/edit commits and replace them with a force-push (
push -f
).